Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(refs)!: remove Reference::Commit variant #697

Merged
merged 1 commit into from
Sep 22, 2024
Merged

fix(refs)!: remove Reference::Commit variant #697

merged 1 commit into from
Sep 22, 2024

Conversation

benpueschel
Copy link
Contributor

Closes: #608

Commits aren't valid refs and using the Reference::Commit variant will always return a 404, so this PR removes the variant altogether.

This PR technically introduces a breaking change, but given that the feature doesn't work anyway, removing it should be safe.

@XAMPPRocky
Copy link
Owner

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit a8bcee4 into XAMPPRocky:main Sep 22, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Sep 12, 2024
Merged
@benpueschel benpueschel deleted the fix-refs branch September 23, 2024 12:59
@emiraga
Copy link

emiraga commented Nov 5, 2024

I believe you are wrong https://docs.github.com/en/repositories/working-with-files/using-files/downloading-source-code-archives#source-code-archive-urls

but workaround is simple

      octocrab
        .repos(&owner, &repo_name)
        .download_tarball(commit_hash)  // it's a String

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference::Commit is based on a documentation error
3 participants
@benpueschel @XAMPPRocky @emiraga